1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
<?php
/**
* Scan source code for incorrect or undeclared modules dependencies
*
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
namespace Magento\Test\Integrity;
use Magento\Framework\App\Utility\Files;
use Magento\Setup\Module\Dependency\Circular;
class CircularDependencyTest extends \PHPUnit\Framework\TestCase
{
/**
* Modules dependencies map
*
* @var array
*/
protected $moduleDependencies = [];
/**
* Circular dependencies
*
* @var array
*/
protected $circularModuleDependencies = [];
public function setUp()
{
$this->buildModulesDependencies();
$this->buildCircularModulesDependencies();
}
/**
* Build modules dependencies
*/
protected function buildModulesDependencies()
{
$configFiles = Files::init()->getConfigFiles('module.xml', [], false);
foreach ($configFiles as $configFile) {
preg_match('#/([^/]+?/[^/]+?)/etc/module\.xml$#', $configFile, $moduleName);
$moduleName = str_replace('/', '_', $moduleName[1]);
$config = simplexml_load_file($configFile);
$result = $config->xpath("/config/module/depends/module") ?: [];
foreach ($result as $node) {
/** @var \SimpleXMLElement $node */
$this->moduleDependencies[$moduleName][] = (string) $node['name'];
}
}
}
/**
* Build circular modules dependencies
*/
protected function buildCircularModulesDependencies()
{
$this->circularModuleDependencies = (new Circular())->buildCircularDependencies($this->moduleDependencies);
}
/**
* Check Magento modules structure for circular dependencies
*/
public function testCircularDependencies()
{
$this->markTestSkipped('Skipped before circular dependencies will be fixed MAGETWO-10938');
if ($this->circularModuleDependencies) {
$result = '';
foreach ($this->circularModuleDependencies as $module => $chains) {
$result .= $module . ' dependencies:' . PHP_EOL;
foreach ($chains as $chain) {
$result .= 'Chain : ' . implode('->', $chain) . PHP_EOL;
}
$result .= PHP_EOL;
}
$this->fail('Circular dependencies:' . PHP_EOL . $result);
}
}
}