1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
namespace Magento\Test\Legacy;
use Magento\Framework\App\Utility\Files;
use Magento\TestFramework\Utility\ClassNameExtractor;
use Magento\TestFramework\Utility\AutogeneratedClassNotInConstructorFinder;
use Magento\TestFramework\Utility\ChangedFiles;
class AutogeneratedClassNotInConstructorTest extends \PHPUnit\Framework\TestCase
{
/**
* @var string[]
*/
private $autogeneratedClassesWhitelist;
/**
* @var ClassNameExtractor
*/
private $classNameExtractor;
/**
* @var AutogeneratedClassNotInConstructorFinder
*/
private $autogeneratedClassNotInConstructorFinder;
/**
* @var Files
*/
private $fileUtilities;
protected function setUp()
{
$this->classNameExtractor = new ClassNameExtractor();
$this->autogeneratedClassNotInConstructorFinder = new AutogeneratedClassNotInConstructorFinder(
$this->classNameExtractor
);
$this->fileUtilities = Files::init();
}
public function testAutogeneratedClassesRequestedInConstructor()
{
$fileTypes = Files::INCLUDE_APP_CODE | Files::INCLUDE_LIBS | Files::INCLUDE_SETUP | Files::AS_DATA_SET;
$changedFiles = ChangedFiles::getPhpFiles(__DIR__ . '/_files/changed_files*', $fileTypes);
$phpFiles = $this->fileUtilities->getPhpFiles($fileTypes);
$existingClasses = [];
$classesCreatedByObjectManager = [];
foreach ($phpFiles as $file) {
$filePath = $file[0];
$fileContent = file_get_contents($filePath);
$className = $this->classNameExtractor->getNameWithNamespace($fileContent);
if ($className) {
$existingClasses = array_merge(
$existingClasses,
[$filePath => $className]
);
}
}
foreach ($changedFiles as $file) {
$filePath = $file[0];
$fileContent = file_get_contents($filePath);
$className = $this->classNameExtractor->getNameWithNamespace($fileContent);
if ($className) {
$tmpClassesCreatedByObjectManager = array_diff(
$this->autogeneratedClassNotInConstructorFinder->find($fileContent),
$this->getWhitelistedClasses()
);
if (!empty($tmpClassesCreatedByObjectManager)) {
$classesCreatedByObjectManager = array_merge(
$classesCreatedByObjectManager,
[$filePath => $tmpClassesCreatedByObjectManager]
);
}
}
}
$existingClasses = array_unique($existingClasses);
$generatedDependenciesNotInConstructor = [];
foreach ($classesCreatedByObjectManager as $key => $classes) {
$autogeneratedClasses = array_diff($classes, $existingClasses);
if (!empty($autogeneratedClasses)) {
$generatedDependenciesNotInConstructor[$key] = $autogeneratedClasses;
}
}
$this->assertEmpty(
$generatedDependenciesNotInConstructor,
"The following autogenerated classes need to be requested in constructor, otherwise compiler "
. "will not be able to find and generate these classes \r\n"
. print_r($generatedDependenciesNotInConstructor, true)
);
}
/**
* Get whitelisted classes
*
* @return string[]
*/
private function getWhitelistedClasses()
{
if (!$this->autogeneratedClassesWhitelist) {
$this->autogeneratedClassesWhitelist = require_once __DIR__
. '/_files/autogenerated_class_not_in_constructor_whitelist.php';
}
return $this->autogeneratedClassesWhitelist;
}
}