1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
namespace Magento\User\Controller\Adminhtml;
use Magento\Framework\App\Request\Http as HttpRequest;
use Magento\TestFramework\Bootstrap;
/**
* @magentoAppArea adminhtml
*/
class UserTest extends \Magento\TestFramework\TestCase\AbstractBackendController
{
/**
* Verify that the main user page contains the user grid
*/
public function testIndexAction()
{
$this->dispatch('backend/admin/user/index');
$response = $this->getResponse()->getBody();
$this->assertContains('Users', $response);
$this->assertEquals(
1,
\Magento\TestFramework\Helper\Xpath::getElementsCountForXpath(
'//*[@id="permissionsUserGrid_table"]',
$response
)
);
}
/**
* Verify that attempting to save a user when no data is present redirects back to the main user page
*/
public function testSaveActionNoData()
{
$this->getRequest()->setMethod(HttpRequest::METHOD_POST);
$this->dispatch('backend/admin/user/save');
$this->assertRedirect($this->stringContains('backend/admin/user/index/'));
}
/**
* Verify that a user cannot be saved if it no longer exists
*
* @magentoDataFixture Magento/User/_files/dummy_user.php
*/
public function testSaveActionWrongId()
{
/** @var $user \Magento\User\Model\User */
$user = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
\Magento\User\Model\User::class
)->loadByUsername(
'dummy_username'
);
$userId = $user->getId();
$this->assertNotEmpty($userId, 'Broken fixture');
$user->delete();
$this->getRequest()->setMethod(HttpRequest::METHOD_POST);
$this->getRequest()->setPostValue('user_id', $userId);
$this->dispatch('backend/admin/user/save');
$this->assertSessionMessages(
$this->equalTo(['This user no longer exists.']),
\Magento\Framework\Message\MessageInterface::TYPE_ERROR
);
$this->assertRedirect($this->stringContains('backend/admin/user/index/'));
}
/**
* Verify that users cannot be saved if the admin password is not correct
*
* @magentoDbIsolation enabled
*/
public function testSaveActionMissingCurrentAdminPassword()
{
$fixture = uniqid();
$this->getRequest()->setMethod(HttpRequest::METHOD_POST);
$this->getRequest()->setPostValue(
[
'username' => $fixture,
'email' => "{$fixture}@example.com",
'firstname' => 'First',
'lastname' => 'Last',
'password' => 'password_with_1_number',
'password_confirmation' => 'password_with_1_number',
]
);
$this->dispatch('backend/admin/user/save');
$this->assertSessionMessages(
$this->equalTo(
['The password entered for the current user is invalid. Verify the password and try again.']
)
);
$this->assertRedirect($this->stringContains('backend/admin/user/edit'));
}
/**
* Verify that users can be successfully saved when data is correct
*
* @magentoDbIsolation enabled
*/
public function testSaveAction()
{
$fixture = uniqid();
$this->getRequest()->setMethod(HttpRequest::METHOD_POST);
$this->getRequest()->setPostValue(
[
'username' => $fixture,
'email' => "{$fixture}@example.com",
'firstname' => 'First',
'lastname' => 'Last',
'password' => 'password_with_1_number',
'password_confirmation' => 'password_with_1_number',
\Magento\User\Block\User\Edit\Tab\Main::CURRENT_USER_PASSWORD_FIELD => Bootstrap::ADMIN_PASSWORD,
]
);
$this->dispatch('backend/admin/user/save');
$this->assertSessionMessages(
$this->equalTo(['You saved the user.']),
\Magento\Framework\Message\MessageInterface::TYPE_SUCCESS
);
$this->assertRedirect($this->stringContains('backend/admin/user/index/'));
}
/**
* Verify that users with the same username or email as an existing user cannot be created
*
* @magentoDbIsolation enabled
* @magentoDataFixture Magento/User/_files/user_with_role.php
*/
public function testSaveActionDuplicateUser()
{
$this->getRequest()->setMethod(HttpRequest::METHOD_POST);
$this->getRequest()->setPostValue(
[
'username' => 'adminUser',
'email' => 'adminUser@example.com',
'firstname' => 'John',
'lastname' => 'Doe',
'password' => \Magento\TestFramework\Bootstrap::ADMIN_PASSWORD,
'password_confirmation' => \Magento\TestFramework\Bootstrap::ADMIN_PASSWORD,
\Magento\User\Block\User\Edit\Tab\Main::CURRENT_USER_PASSWORD_FIELD => Bootstrap::ADMIN_PASSWORD,
]
);
$this->dispatch('backend/admin/user/save/active_tab/main_section');
$this->assertSessionMessages(
$this->equalTo(['A user with the same user name or email already exists.']),
\Magento\Framework\Message\MessageInterface::TYPE_ERROR
);
$this->assertRedirect($this->stringContains('backend/admin/user/edit/'));
$this->assertRedirect($this->matchesRegularExpression('/^((?!active_tab).)*$/'));
}
/**
* Verify password change properly updates fields when the request is valid.
*
* @param array $postData
* @param bool $isPasswordCorrect
*
* @magentoDbIsolation enabled
* @dataProvider saveActionPasswordChangeDataProvider
*/
public function testSaveActionPasswordChange($postData, $isPasswordCorrect)
{
$this->getRequest()->setMethod(HttpRequest::METHOD_POST);
$this->getRequest()->setPostValue($postData);
$this->dispatch('backend/admin/user/save');
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
/** @var $user \Magento\User\Model\User */
$user = $objectManager->create(\Magento\User\Model\User::class);
$user->loadByUsername($postData['username']);
if ($isPasswordCorrect) {
$this->assertRedirect($this->stringContains('backend/admin/user/index'));
$this->assertEquals($postData['username'], $user->getUsername());
$this->assertEquals($postData['email'], $user->getEmail());
$this->assertEquals($postData['firstname'], $user->getFirstname());
$this->assertEquals($postData['lastname'], $user->getLastname());
$encryptor = $objectManager->get(\Magento\Framework\Encryption\EncryptorInterface::class);
$this->assertTrue($encryptor->validateHash($postData['password'], $user->getPassword()));
} else {
$this->assertRedirect($this->stringContains('backend/admin/user/edit'));
$this->assertEmpty($user->getData());
}
}
/**
* Dataprovider for testSaveActionPasswordChange
*
* @return array
*/
public function saveActionPasswordChangeDataProvider()
{
$password = uniqid('123q');
$passwordPairs = [
['password' => $password, 'password_confirmation' => $password, 'is_correct' => true],
['password' => $password, 'password_confirmation' => '', 'is_correct' => false],
['password' => $password, 'password_confirmation' => $password . '123', 'is_correct' => false],
['password' => '', 'password_confirmation' => '', 'is_correct' => false],
['password' => '', 'password_confirmation' => $password, 'is_correct' => false],
];
$data = [];
foreach ($passwordPairs as $passwordPair) {
$fixture = uniqid();
$postData = [
'username' => $fixture,
'email' => "{$fixture}@example.com",
'firstname' => 'First',
'lastname' => 'Last',
'password' => $passwordPair['password'],
'password_confirmation' => $passwordPair['password_confirmation'],
\Magento\User\Block\User\Edit\Tab\Main::CURRENT_USER_PASSWORD_FIELD => Bootstrap::ADMIN_PASSWORD,
];
$data[] = [$postData, $passwordPair['is_correct']];
}
return $data;
}
/**
* Verify that the role grid is present when requested
*/
public function testRoleGridAction()
{
$this->getRequest()->setParam('ajax', true)->setParam('isAjax', true);
$this->dispatch('backend/admin/user/roleGrid');
$expected = '%a<table %a id="permissionsUserGrid_table">%a';
$this->assertStringMatchesFormat($expected, $this->getResponse()->getBody());
}
/**
* Verify that the roles grid is present when requested
*
* @depends testSaveAction
*/
public function testRolesGridAction()
{
$this->getRequest()->setParam('ajax', true)->setParam('isAjax', true)->setParam('user_id', 1);
$this->dispatch('backend/admin/user/rolesGrid');
$expected = '%a<table %a id="permissionsUserRolesGrid_table">%a';
$this->assertStringMatchesFormat($expected, $this->getResponse()->getBody());
}
/**
* Verify that expected header and fieldsets are present for edit
*
* @depends testSaveAction
*/
public function testEditAction()
{
$this->getRequest()->setParam('user_id', 1);
$this->dispatch('backend/admin/user/edit');
$response = $this->getResponse()->getBody();
//check "User Information" header and fieldset
$this->assertContains('data-ui-id="adminhtml-user-edit-tabs-title"', $response);
$this->assertContains('User Information', $response);
$this->assertEquals(
1,
\Magento\TestFramework\Helper\Xpath::getElementsCountForXpath(
'//*[@id="user_base_fieldset"]',
$response
)
);
}
/**
* Verify that validation passes on correct data
*/
public function testValidateActionSuccess()
{
$data = [
'username' => 'admin2',
'firstname' => 'new firstname',
'lastname' => 'new lastname',
'email' => 'example@domain.com',
'password' => 'password123',
'password_confirmation' => 'password123',
];
$this->getRequest()->setPostValue($data);
$this->dispatch('backend/admin/user/validate');
$body = $this->getResponse()->getBody();
$this->assertEquals('{"error":0}', $body);
}
/**
* Verify that an unknown top level domain on an email address does not fail validation
*/
public function testValidateActionUnknownTldSuccess()
{
$data = [
'username' => 'admin2',
'firstname' => 'new firstname',
'lastname' => 'new lastname',
'email' => 'example@domain.unknown',
'password' => 'password123',
'password_confirmation' => 'password123',
];
$this->getRequest()->setPostValue($data);
$this->dispatch('backend/admin/user/validate');
$body = $this->getResponse()->getBody();
$this->assertEquals('{"error":0}', $body);
}
/**
* Verify that an invalid email address format fails the validation
*/
public function testValidateActionError()
{
$data = [
'username' => 'admin2',
'firstname' => 'new firstname',
'lastname' => 'new lastname',
'email' => 'example@-domain.cim',
'password' => 'password123',
'password_confirmation' => 'password123',
];
/**
* set customer data
*/
$this->getRequest()->setPostValue($data);
$this->dispatch('backend/admin/user/validate');
$body = $this->getResponse()->getBody();
$this->assertContains('{"error":1,"html_message":', $body);
$this->assertContains("'-domain.cim' is not a valid hostname for email address 'example@-domain.cim", $body);
}
}